[webkit-reviews] review granted: [Bug 214774] Fixed exception check handling below ScheduledAction::executeFunctionInContext() : [Attachment 405209] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 214774: Fixed exception check handling below
ScheduledAction::executeFunctionInContext()
https://bugs.webkit.org/show_bug.cgi?id=214774

Attachment 405209: Patch

https://bugs.webkit.org/attachment.cgi?id=405209&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 405209
  --> https://bugs.webkit.org/attachment.cgi?id=405209
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405209&action=review

r=me with fixes.

> Source/WebCore/bindings/js/ScheduledAction.cpp:122
> +    EXCEPTION_ASSERT(catchScope.exception() == exception);

This should be `EXCEPTION_ASSERT(!catchScope.exception());` because by the time
profiledCall() returns, it should have cleared the exception and return it via
the NakedPtr.

> LayoutTests/js/dom/scheduled-action-exception-checks.html:1
> +<script>

Take a look at
LayoutTests/js/dom/missing-exception-check-below-queueMicrotask.html and due
the same with the stuff surrounding the script: they pass the needed JSC option
and also make the test output cleaner.	Please rebase the expected results
after you do that.