[webkit-reviews] review granted: [Bug 214712] steps() timing function on a transform animation triggers a render every frame : [Attachment 405129] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 214712: steps() timing function on a transform animation triggers a render
every frame
https://bugs.webkit.org/show_bug.cgi?id=214712

Attachment 405129: Patch

https://bugs.webkit.org/attachment.cgi?id=405129&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 405129
  --> https://bugs.webkit.org/attachment.cgi?id=405129
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405129&action=review

> Source/WebCore/animation/KeyframeEffect.cpp:1558
> +    computeSomeKeyframesUseStepsTimingFunction();

what an interesting function name! (but not new)

>> Source/WebCore/animation/KeyframeEffect.h:214
>> +	Optional<bool> m_isRunningAccelerated;
> 
> I'm really not a fan of using Optional<bool> (outside of a something decoding
a bool value or similar uses). I almost never understand what it is trying to
represent. In most cases an enum is much clearer. I think that would be true
here too.

You'd rather a yes/no/IDK-yet tristate?