[webkit-reviews] review granted: [Bug 126448] [WebGL2] Framebuffer and renderbuffer updates : [Attachment 405104] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kenneth Russell <kbr at google.com>'s
request for review:
Bug 126448: [WebGL2] Framebuffer and renderbuffer updates
https://bugs.webkit.org/show_bug.cgi?id=126448

Attachment 405104: Patch

https://bugs.webkit.org/attachment.cgi?id=405104&action=review




--- Comment #9 from Dean Jackson <dino at apple.com> ---
Comment on attachment 405104
  --> https://bugs.webkit.org/attachment.cgi?id=405104
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405104&action=review

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:760
> +	   if (!validateTexFuncLayer("framebufferTextureLayer", texTarget,
layer))
> +	       return;
> +	   if (!validateTexFuncLevel("framebufferTextureLayer", texTarget,
level))
> +	       return;

Took me a few reads to work out what was different :)

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:887
> +    Vector<GCGLenum> translatedAttachments = attachments;
> +    if (!checkAndTranslateAttachments("invalidateFramebuffer", target,
translatedAttachments))

Since you're taking a copy anyway, why not have checkAndTranslateAttachments
return a translated vector?