[webkit-reviews] review granted: [Bug 214669] Web Inspector: developerExtrasEnabled should be respected when opening local Web Inspector (part 2) : [Attachment 405004] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 214669: Web Inspector: developerExtrasEnabled should be respected when
opening local Web Inspector (part 2)
https://bugs.webkit.org/show_bug.cgi?id=214669

Attachment 405004: Patch

https://bugs.webkit.org/attachment.cgi?id=405004&action=review




--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 405004
  --> https://bugs.webkit.org/attachment.cgi?id=405004
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405004&action=review

>>> Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp:671
>>> +	     return;
>> 
>> How would it be possible to get here?
> 
> A compromised WebContent process may try to trick UIProcess into using
Inspector functionality even if it's disabled. We don't want that to happen.

Sounds good. Is this the only command then? It seems
`WebInspectorProxy::append` could be concerning as well.