[webkit-reviews] review granted: [Bug 214583] Allow IndexedDB in third-party frames : [Attachment 405019] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 214583: Allow IndexedDB in third-party frames
https://bugs.webkit.org/show_bug.cgi?id=214583

Attachment 405019: Patch

https://bugs.webkit.org/attachment.cgi?id=405019&action=review




--- Comment #8 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 405019
  --> https://bugs.webkit.org/attachment.cgi?id=405019
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405019&action=review

r=me

> Source/WebCore/Modules/indexeddb/IDBFactory.cpp:58
> +    if (!context.securityOrigin()->canAccessDatabase(nullptr))
>	   return true;

This check looks a little mysterious. It's nice that we're being consistent
with LocalStorage here. Probably deserves some follow-up for both LocalStorage
and IDB to make this check clearer.