[webkit-reviews] review granted: [Bug 214631] Monitor the case of a fetch event not able to register to the respondWith promise : [Attachment 404914] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 214631: Monitor the case of a fetch event not able to register to the
respondWith promise
https://bugs.webkit.org/show_bug.cgi?id=214631

Attachment 404914: Patch

https://bugs.webkit.org/attachment.cgi?id=404914&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 404914
  --> https://bugs.webkit.org/attachment.cgi?id=404914
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404914&action=review

> Source/WebCore/bindings/js/JSDOMPromise.h:53
> +    static bool whenPromiseIsSettled(JSDOMGlobalObject*, JSC::JSObject*
promise, Function<void()>&&);

I think this needs a 2-state enum.  "true" and "false" don't really make sense
here.

> Source/WebCore/workers/service/FetchEvent.cpp:78
> +    bool isRegistered = m_respondPromise->whenSettled([this, protectedThis =
makeRef(*this)] () {

() is unnecessary.