[webkit-reviews] review requested: [Bug 213364] [GStreamer] gst_buffer_unmap: assertion 'GST_IS_BUFFER (buffer)' failed : [Attachment 405035] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 23 07:07:38 PDT 2020


Xabier Rodríguez Calvar <calvaris at igalia.com> has asked  for review:
Bug 213364: [GStreamer] gst_buffer_unmap: assertion 'GST_IS_BUFFER (buffer)'
failed
https://bugs.webkit.org/show_bug.cgi?id=213364

Attachment 405035: Patch

https://bugs.webkit.org/attachment.cgi?id=405035&action=review




--- Comment #9 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Created attachment 405035

  --> https://bugs.webkit.org/attachment.cgi?id=405035&action=review

Patch

(In reply to Philippe Normand from comment #8)
> Comment on attachment 404934 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=404934&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:121
> > +	 uint8_t* data() { ASSERT(m_isValid); return
static_cast<uint8_t*>(m_info.data); }
> 
> Should this one be moved to GstMappedOwnedBuffer?

No, owned is only for readonly, if something is for writing is the superclass.

I re-uploaded the patch with some more checks for memory safety.


More information about the webkit-reviews mailing list