[webkit-reviews] review granted: [Bug 214610] We should have exception check after promise operation : [Attachment 405029] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 214610: We should have exception check after promise operation
https://bugs.webkit.org/show_bug.cgi?id=214610

Attachment 405029: Patch

https://bugs.webkit.org/attachment.cgi?id=405029&action=review




--- Comment #5 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 405029
  --> https://bugs.webkit.org/attachment.cgi?id=405029
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405029&action=review

> Source/WebCore/bindings/js/JSDOMPromiseDeferred.cpp:187
> +    EXCEPTION_ASSERT(!scope.exception() ||
isTerminatedExecutionException(lexicalGlobalObject.vm(), scope.exception()));

Should we add this line in other places like reject(Exception...)?