[webkit-reviews] review granted: [Bug 213364] [GStreamer] gst_buffer_unmap: assertion 'GST_IS_BUFFER (buffer)' failed : [Attachment 404934] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 213364: [GStreamer] gst_buffer_unmap: assertion 'GST_IS_BUFFER (buffer)'
failed
https://bugs.webkit.org/show_bug.cgi?id=213364

Attachment 404934: Patch

https://bugs.webkit.org/attachment.cgi?id=404934&action=review




--- Comment #8 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 404934
  --> https://bugs.webkit.org/attachment.cgi?id=404934
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404934&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:121
> +    uint8_t* data() { ASSERT(m_isValid); return
static_cast<uint8_t*>(m_info.data); }

Should this one be moved to GstMappedOwnedBuffer?