[webkit-reviews] review granted: [Bug 214665] [IPC hardening] WebKit::ArgumentCoder<BlobPart>::decode() and encode() should use enum BlobPart::Type : [Attachment 404997] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 214665: [IPC hardening] WebKit::ArgumentCoder<BlobPart>::decode() and
encode() should use enum BlobPart::Type
https://bugs.webkit.org/show_bug.cgi?id=214665

Attachment 404997: Patch v1

https://bugs.webkit.org/attachment.cgi?id=404997&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 404997
  --> https://bugs.webkit.org/attachment.cgi?id=404997
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=404997&action=review

> Source/WebCore/platform/network/BlobPart.h:100
> +namespace WTF {
> +
> +template<> struct EnumTraits<WebCore::BlobPart::Type> {
> +    using values = EnumValues<
> +	   WebCore::BlobPart::Type,
> +	   WebCore::BlobPart::Type::Data,
> +	   WebCore::BlobPart::Type::Blob
> +    >;
> +};
> +
> +} // namespace WTF

Instead of this, I suggest:

    enum class Type : bool { Data, Blob };