[webkit-reviews] review granted: [Bug 214666] [Cocoa|WebM] Decode error when seeking : [Attachment 404999] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 22 18:03:36 PDT 2020


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 214666: [Cocoa|WebM] Decode error when seeking
https://bugs.webkit.org/show_bug.cgi?id=214666

Attachment 404999: Patch

https://bugs.webkit.org/attachment.cgi?id=404999&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 404999
  --> https://bugs.webkit.org/attachment.cgi?id=404999
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404999&action=review

> Source/WebCore/ChangeLog:8
> +	   A decoder error is hit when seeking because we think all samples
coming out of the SourceBufferParserWebM is a sync-sample.

There is a tense problem here: "all samples ... is a sync-sample"


More information about the webkit-reviews mailing list