[webkit-reviews] review granted: [Bug 211156] [WebGL2] Implement multiple render target entry points : [Attachment 404955] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kenneth Russell <kbr at google.com>'s
request for review:
Bug 211156: [WebGL2] Implement multiple render target entry points
https://bugs.webkit.org/show_bug.cgi?id=211156

Attachment 404955: Patch

https://bugs.webkit.org/attachment.cgi?id=404955&action=review




--- Comment #18 from Dean Jackson <dino at apple.com> ---
Comment on attachment 404955
  --> https://bugs.webkit.org/attachment.cgi?id=404955
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404955&action=review

> Source/WebCore/html/canvas/WebGLFramebuffer.cpp:626
> +	   // This filtering works around graphics driver bugs on Mac OS X.

Nit: macOS

>> Source/WebCore/platform/graphics/GraphicsContextGL.h:1122
>> +	virtual void enablePreserveDrawingBuffer();
> 
> This is the first non-pure virtual in GraphicsContextGL, and it's necessary
because m_attrs is private in this class. Is this OK from an architectural
standpoint?

This is probably ok. The alternative would be to use
GraphicsContextGL::setContextAttributes.