[webkit-reviews] review denied: [Bug 214615] Added PeriodicWave constructor according to spec : [Attachment 404969] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 22 14:55:56 PDT 2020


Chris Dumez <cdumez at apple.com> has denied  review:
Bug 214615: Added PeriodicWave constructor according to spec
https://bugs.webkit.org/show_bug.cgi?id=214615

Attachment 404969: Patch

https://bugs.webkit.org/attachment.cgi?id=404969&action=review




--- Comment #9 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 404969
  --> https://bugs.webkit.org/attachment.cgi?id=404969
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404969&action=review

> Source/WebCore/Modules/webaudio/PeriodicWave.h:32
> +#include "BaseAudioContext.h"

This should have been added to the cpp, not the header. It should remain a
forward declaration in the header.


More information about the webkit-reviews mailing list