[webkit-reviews] review granted: [Bug 213638] [JSC] Add Intl.Segmenter : [Attachment 404896] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 213638: [JSC] Add Intl.Segmenter
https://bugs.webkit.org/show_bug.cgi?id=213638

Attachment 404896: Patch

https://bugs.webkit.org/attachment.cgi?id=404896&action=review




--- Comment #3 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 404896
  --> https://bugs.webkit.org/attachment.cgi?id=404896
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404896&action=review

r=me. I'm sad that we don't have test262 tests yet, but it's behind a flag, so
we can keep tweaking things.

> Source/JavaScriptCore/runtime/IntlSegmenter.cpp:180
> +	   result->putDirect(vm, vm.propertyNames->isWordLike,
jsBoolean(!(ruleStatus >= UBRK_WORD_NONE && ruleStatus <=
UBRK_WORD_NONE_LIMIT)));

Seems like DeMorgan's rule wouldn't make this less clear?
  jsBoolean(ruleStatus < UBRK_WORD_NONE || ruleStatus > UBRK_WORD_NONE_LIMIT)