[webkit-reviews] review granted: [Bug 214611] Web Inspector: Sources tab empty, sidebar nonfunctional : [Attachment 404936] Proposed fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 214611: Web Inspector: Sources tab empty, sidebar nonfunctional
https://bugs.webkit.org/show_bug.cgi?id=214611

Attachment 404936: Proposed fix

https://bugs.webkit.org/attachment.cgi?id=404936&action=review




--- Comment #11 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 404936
  --> https://bugs.webkit.org/attachment.cgi?id=404936
Proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=404936&action=review

r=me, looks reasonable

> Source/WebInspectorUI/UserInterface/Views/IssueTreeElement.js:64
> +	       var lineNumberLabel;

NIT: this can be `let` too :)

> Source/WebInspectorUI/UserInterface/Views/IssueTreeElement.js:70
> +	       this.mainTitle = `${lineNumberLabel}
${this._issueMessage.text}`;

NIT: I personally prefer not using a template string for simple combinations
like this, as it's harder to notice the space vs when it's explicitly done as
`" "` with an addition