[webkit-reviews] review granted: [Bug 214641] [32-bits] Fixing the return of doVMEntry into LowLevelInterpreter32_64.asm : [Attachment 404921] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Caio Lima <ticaiolima at gmail.com>'s
request for review:
Bug 214641: [32-bits] Fixing the return of doVMEntry into
LowLevelInterpreter32_64.asm
https://bugs.webkit.org/show_bug.cgi?id=214641

Attachment 404921: Patch

https://bugs.webkit.org/attachment.cgi?id=404921&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 404921
  --> https://bugs.webkit.org/attachment.cgi?id=404921
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404921&action=review

r=me

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:331
> +    move UndefinedTag, r1
> +    move 0, r0

Can you just put a comment above this that says that this is in little endian
order?	That will make it easier if anyone tries to make big endian work, and
need to grep for search for places to make needed changes.  A comment is cheap
and can be so helpful here.