[webkit-reviews] review granted: [Bug 213493] [WPE][GTK] Add API to support "Privacy Report" : [Attachment 404913] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 213493: [WPE][GTK] Add API to support "Privacy Report"
https://bugs.webkit.org/show_bug.cgi?id=213493

Attachment 404913: Patch

https://bugs.webkit.org/attachment.cgi?id=404913&action=review




--- Comment #18 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 404913
  --> https://bugs.webkit.org/attachment.cgi?id=404913
Patch

Patch LGTM overall, but there are a couple of types and a an introspection
annotation which needs fixing, so please check the comments below before
landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=404913&action=review

> Source/WTF/ChangeLog:8
> +	   Add support for using GRePtr with GDateTime.

Typo: GRePtr → GRefPtr

> Source/WebKit/ChangeLog:8
> +	   Add WebKitITPFirstParty and WebKitITPThirdParty bosex types to
expose the data returned by the ITP summary.

Typo: bosex → boxed

> Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp:1221
> + * Returns: (transfer full): the last update time as a #GDateTime

The implementation returns the pointer directly, without adding a
reference, therefore the annotation here should be “(transfer none)”.