[webkit-reviews] review granted: [Bug 206403] Safari does not present CertificateInfo for service-worker served documents : [Attachment 404898] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 206403: Safari does not present CertificateInfo for service-worker served
documents
https://bugs.webkit.org/show_bug.cgi?id=206403

Attachment 404898: Patch

https://bugs.webkit.org/attachment.cgi?id=404898&action=review




--- Comment #14 from Darin Adler <darin at apple.com> ---
Comment on attachment 404898
  --> https://bugs.webkit.org/attachment.cgi?id=404898
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404898&action=review

> Source/WebCore/platform/network/cf/CertificateInfoCFNet.cpp:53
> +    CertificateInfo copy;
> +#if HAVE(SEC_TRUST_SERIALIZATION)
> +    copy.m_trust = m_trust;
> +#endif
> +    copy.m_certificateChain = m_certificateChain;
> +    return copy;

Since there is nothing to isolate, can just write this:

    return *this;

Could even put it inline in the header if you like.