[webkit-reviews] review granted: [Bug 214619] Web Inspector: inspector/canvas/memory.html is failing on macOS Apple Silicon : [Attachment 404870] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 21 16:07:09 PDT 2020
Devin Rousso <drousso at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 214619: Web Inspector: inspector/canvas/memory.html is failing on macOS
Apple Silicon
https://bugs.webkit.org/show_bug.cgi?id=214619
Attachment 404870: Patch
https://bugs.webkit.org/attachment.cgi?id=404870&action=review
--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 404870
--> https://bugs.webkit.org/attachment.cgi?id=404870
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=404870&action=review
r=me
> LayoutTests/inspector/canvas/memory.html:59
> + InspectorTest.expectGreaterThan(event.target.memoryCost,
isNaN(initialMemoryCost) ? 0 : initialMemoryCost, "Memory cost should increase
upon initially resizing canvas.");
NIT: this shouldn't be `NaN`, but I suppose it couldn't hurt to check
More information about the webkit-reviews
mailing list