[webkit-reviews] review granted: [Bug 214425] REGRESSION(r264486): ASSERTION FAILED: ASSERT_NOT_REACHED() in NetworkProcessPlatformStrategies::createBlobRegistry : [Attachment 404724] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 214425: REGRESSION(r264486): ASSERTION FAILED: ASSERT_NOT_REACHED() in
NetworkProcessPlatformStrategies::createBlobRegistry
https://bugs.webkit.org/show_bug.cgi?id=214425

Attachment 404724: Patch

https://bugs.webkit.org/attachment.cgi?id=404724&action=review




--- Comment #8 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 404724
  --> https://bugs.webkit.org/attachment.cgi?id=404724
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404724&action=review

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:3161
> +		   return jsNull();

We will not call readFile so will not be able to advance m_ptr.
We should probably do this check after readFile.
Ditto for FileListTag.

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:3198
> +		   ASSERT_NOT_REACHED();

This change is not explained and is somehow counter intuitive.
Why not: "if (m_isJSIDBSerializationGlobalObject) ..." without the
ASSERT_NOT_REACHED?