[webkit-reviews] review granted: [Bug 214554] [GTK] WebKitSettings:enable-private-browsing missing G_PARAM_DEPRECATED : [Attachment 404717] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 20 23:58:06 PDT 2020
Carlos Garcia Campos <cgarcia at igalia.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 214554: [GTK] WebKitSettings:enable-private-browsing missing
G_PARAM_DEPRECATED
https://bugs.webkit.org/show_bug.cgi?id=214554
Attachment 404717: Patch
https://bugs.webkit.org/attachment.cgi?id=404717&action=review
--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 404717
--> https://bugs.webkit.org/attachment.cgi?id=404717
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=404717&action=review
> Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:957
> +
readWriteConstructParamFlags | G_PARAM_DEPRECATED));
You need a cast here. This doesn't build.
More information about the webkit-reviews
mailing list