[webkit-reviews] review granted: [Bug 214586] Fix FinalizationRegistry GC finalizer interation : [Attachment 404791] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 20 22:04:26 PDT 2020


Mark Lam <mark.lam at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 214586: Fix FinalizationRegistry GC finalizer interation
https://bugs.webkit.org/show_bug.cgi?id=214586

Attachment 404791: Patch

https://bugs.webkit.org/attachment.cgi?id=404791&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 404791
  --> https://bugs.webkit.org/attachment.cgi?id=404791
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404791&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +	   Turns out when you remove the ith element from an table and you

/an table/a Vector/.  I think the data structure you're using is a Vector,
right?


More information about the webkit-reviews mailing list