[webkit-reviews] review granted: [Bug 163834] TryGetById clobberize rules are wrong : [Attachment 404782] proposed patch.

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 163834: TryGetById clobberize rules are wrong
https://bugs.webkit.org/show_bug.cgi?id=163834

Attachment 404782: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=404782&action=review




--- Comment #10 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 404782
  --> https://bugs.webkit.org/attachment.cgi?id=404782
proposed patch.

r=me. Assuming I'm right in my thinking that we shouldn't, correctly, writing
to the stack in TryGetById, can you add a comment to the ChangeLog that we are
slightly more conservative than necessary? I can't think of a way we can do
that off the top of my head today. However, I think the right answer is to just
assume some future world where we will ask what our caller is or something.