[webkit-reviews] review granted: [Bug 214194] EWS should set cq- flag when a patch fails to build or introduces layout-test failures : [Attachment 403993] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 214194: EWS should set cq- flag when a patch fails to build or introduces
layout-test failures
https://bugs.webkit.org/show_bug.cgi?id=214194

Attachment 403993: Patch

https://bugs.webkit.org/attachment.cgi?id=403993&action=review




--- Comment #6 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 403993
  --> https://bugs.webkit.org/attachment.cgi?id=403993
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403993&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:1941
> +	      
self.build.addStepsAfterCurrentStep([SetCommitQueueMinusFlagOnPatch()])

To clarify, this only does anything if a patch is in commit queue and tests
fail before it lands, right?