[webkit-reviews] review granted: [Bug 169811] [GStreamer] Add support for canvas captureStream, tests failing since they were added in r213598 : [Attachment 404719] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 169811: [GStreamer] Add support for canvas captureStream, tests failing
since they were added in r213598
https://bugs.webkit.org/show_bug.cgi?id=169811

Attachment 404719: Patch

https://bugs.webkit.org/attachment.cgi?id=404719&action=review




--- Comment #31 from Darin Adler <darin at apple.com> ---
Comment on attachment 404719
  --> https://bugs.webkit.org/attachment.cgi?id=404719
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404719&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:52
>      auto status = CVPixelBufferCreateWithBytes(kCFAllocatorDefault, width,
height, kCVPixelFormatType_32BGRA, array.data(), width * 4, releaseUint8Vector,
array.releaseBuffer().leakPtr(), NULL, &pixelBuffer);

This code has the same bug as the mistake in GStreamer, calling data() and
releaseBuffer() and depending on order of evaluation, and needs the same kind
of fix.