[webkit-reviews] review granted: [Bug 214515] [CG] Flushing ImageBuffer IOSurface cached image can happen when creating an image for encoding only : [Attachment 404688] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 214515: [CG] Flushing ImageBuffer IOSurface cached image can happen when
creating an image for encoding only
https://bugs.webkit.org/show_bug.cgi?id=214515

Attachment 404688: Patch

https://bugs.webkit.org/attachment.cgi?id=404688&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 404688
  --> https://bugs.webkit.org/attachment.cgi?id=404688
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404688&action=review

> Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.h:71
> +    mutable bool m_pendingFlushCachedImage { false };

I think this needs a better name. Maybe m_requiresDrawAfterPutImageData or
something. It's not really a "pending" (that's used for "something is going to
happen in future").

Can we set m_pendingFlushCachedImage to false whenever any other CG drawing
takes place as well?