[webkit-reviews] review granted: [Bug 214418] CSS clip-path is applied to the <svg> root element in the view-box coordinates : [Attachment 404528] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 19 12:27:19 PDT 2020


Darin Adler <darin at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 214418: CSS clip-path is applied to the <svg> root element in the view-box
coordinates
https://bugs.webkit.org/show_bug.cgi?id=214418

Attachment 404528: Patch

https://bugs.webkit.org/attachment.cgi?id=404528&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 404528
  --> https://bugs.webkit.org/attachment.cgi?id=404528
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404528&action=review

> Source/WebCore/rendering/svg/SVGRenderSupport.cpp:401
> +	   // Transfer referenceBox to CSS coordinates if needed.

Please omit this comment. It just says what the code says.

> Source/WebCore/rendering/svg/SVGRenderSupport.cpp:405
> +	   // Transfer path back to SVG coordinates.

Ditto.


More information about the webkit-reviews mailing list