[webkit-reviews] review granted: [Bug 214521] Remove ColorBuilder : [Attachment 404678] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 214521: Remove ColorBuilder
https://bugs.webkit.org/show_bug.cgi?id=214521

Attachment 404678: Patch

https://bugs.webkit.org/attachment.cgi?id=404678&action=review




--- Comment #13 from Darin Adler <darin at apple.com> ---
Comment on attachment 404678
  --> https://bugs.webkit.org/attachment.cgi?id=404678
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404678&action=review

> Source/WebCore/accessibility/AccessibilityTable.cpp:288
> +		   && tableBGColor != cellColor && cellColor.alphaByte() != 1)
// FIXME (https://bugs.webkit.org/show_bug.cgi?id=214537): This comparison to 1
is likely incorrect. It likely should be checking !cellColor.isOpaque().

Renaming FTW! Someone needs to add a test case now.

> Source/WebCore/rendering/RenderThemeIOS.mm:337
>      if (isChecked(box)) {
> -	  
ASSERT(style.visitedDependentColor(CSSPropertyBorderTopColor).alpha() % 255 ==
0);
> -	  
ASSERT(style.visitedDependentColor(CSSPropertyBorderRightColor).alpha() % 255
== 0);
> -	  
ASSERT(style.visitedDependentColor(CSSPropertyBorderBottomColor).alpha() % 255
== 0);
> -	  
ASSERT(style.visitedDependentColor(CSSPropertyBorderLeftColor).alpha() % 255 ==
0);
> +	  
ASSERT(style.visitedDependentColor(CSSPropertyBorderTopColor).alphaByte() % 255
== 0);
> +	  
ASSERT(style.visitedDependentColor(CSSPropertyBorderRightColor).alphaByte() %
255 == 0);
> +	  
ASSERT(style.visitedDependentColor(CSSPropertyBorderBottomColor).alphaByte() %
255 == 0);
> +	  
ASSERT(style.visitedDependentColor(CSSPropertyBorderLeftColor).alphaByte() %
255 == 0);
>      }

Could rewrite these to a less silly style some day.