[webkit-reviews] review granted: [Bug 169811] [GStreamer] Add support for canvas captureStream, tests failing since they were added in r213598 : [Attachment 404677] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 169811: [GStreamer] Add support for canvas captureStream, tests failing
since they were added in r213598
https://bugs.webkit.org/show_bug.cgi?id=169811

Attachment 404677: Patch

https://bugs.webkit.org/attachment.cgi?id=404677&action=review




--- Comment #16 from Darin Adler <darin at apple.com> ---
Comment on attachment 404677
  --> https://bugs.webkit.org/attachment.cgi?id=404677
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404677&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp:114
> +    GstCaps* caps = gst_sample_get_caps(m_sample.get());

auto?

> Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h:40
> +    static RefPtr<MediaSampleGStreamer> createImageSample(Vector<uint8_t>&&,
unsigned long width, unsigned long height);

This should return Ref, not RefPtr.

This should take unsigned, not unsigned long.

> Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h:58
> +    RefPtr<JSC::Uint8ClampedArray> getRGBAImageData() const override;

final instead of override?