[webkit-reviews] review granted: [Bug 214522] Rename Color::transparent to Color::transparentBlack to more clearly state what it is : [Attachment 404645] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 19 08:42:44 PDT 2020


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 214522: Rename Color::transparent to Color::transparentBlack to more
clearly state what it is
https://bugs.webkit.org/show_bug.cgi?id=214522

Attachment 404645: Patch

https://bugs.webkit.org/attachment.cgi?id=404645&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 404645
  --> https://bugs.webkit.org/attachment.cgi?id=404645
Patch

Should we also consider using the named version less? I think that sometimes
returning { } instead of Color::transparentBlack would represent our intent
more clearly.


More information about the webkit-reviews mailing list