[webkit-reviews] review granted: [Bug 214451] Only use enum classes in HTTPParsers : [Attachment 404557] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 214451: Only use enum classes in HTTPParsers
https://bugs.webkit.org/show_bug.cgi?id=214451

Attachment 404557: Patch

https://bugs.webkit.org/attachment.cgi?id=404557&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 404557
  --> https://bugs.webkit.org/attachment.cgi?id=404557
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404557&action=review

> Source/WebCore/platform/network/HTTPParsers.h:50
> +enum class ContentTypeOptionsDisposition {

Could you add a base type? Maybe bool or uint8_t.

> Source/WebCore/platform/network/HTTPParsers.h:55
> +enum class XFrameOptionsDisposition {

Here too.