[webkit-reviews] review granted: [Bug 213900] [WebAuthn] Cache the PIN to improve NFC user experience : [Attachment 404364] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 213900: [WebAuthn] Cache the PIN to improve NFC user experience
https://bugs.webkit.org/show_bug.cgi?id=213900

Attachment 404364: Patch

https://bugs.webkit.org/attachment.cgi?id=404364&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 404364
  --> https://bugs.webkit.org/attachment.cgi?id=404364
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404364&action=review

r=me

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:284
> +    // issue. The probability of the issue, however, should be rare.

I think this is pretty well documented in the Bugzilla.

I would suggest a shorter note:

// Cache the PIN to improve NFC user experience so that a momentary movement of
the NFC key away from the scanner doesn't force the PIN entry to be re-entered.

Question: Should this have some kind of timeout to clear it if some period of
time passes?

That might be a reasonable followup patch if you think it's needed. I don't
think it's required here.