[webkit-reviews] review granted: [Bug 214441] Fix -Wformat= warnings when passing enum to integer specifiers : [Attachment 404535] Patch using uint8_t as underlying type

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Lauro Moura <lmoura at igalia.com>'s
request for review:
Bug 214441: Fix -Wformat= warnings when passing enum to integer specifiers
https://bugs.webkit.org/show_bug.cgi?id=214441

Attachment 404535: Patch using uint8_t as underlying type

https://bugs.webkit.org/attachment.cgi?id=404535&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 404535
  --> https://bugs.webkit.org/attachment.cgi?id=404535
Patch using uint8_t as underlying type

Seems OK. Awkward to have to write static_cast<int> out each time. Would have
thought that an underlying type would help, and there would be some simple
format string we could use, but not really sure how that all works with integer
type promotion and all the PRIxx stuff.