[webkit-reviews] review granted: [Bug 214439] Remove final vestigates of SimpleColor : [Attachment 404529] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 214439: Remove final vestigates of SimpleColor
https://bugs.webkit.org/show_bug.cgi?id=214439

Attachment 404529: Patch

https://bugs.webkit.org/attachment.cgi?id=404529&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 404529
  --> https://bugs.webkit.org/attachment.cgi?id=404529
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404529&action=review

> Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:170
> +    categories[MemoryCategory::JSJIT] =
HistoricMemoryCategoryInfo(MemoryCategory::JSJIT, SRGBA<uint8_t> { 255, 96, 255
}, "JS JIT");
> +    categories[MemoryCategory::Gigacage] =
HistoricMemoryCategoryInfo(MemoryCategory::Gigacage, SRGBA<uint8_t> { 101, 79,
240 }, "Gigacage");
> +    categories[MemoryCategory::Images] =
HistoricMemoryCategoryInfo(MemoryCategory::Images, Color::yellow, "Images");
> +    categories[MemoryCategory::Layers] =
HistoricMemoryCategoryInfo(MemoryCategory::Layers, Color::cyan, "Layers");
> +    categories[MemoryCategory::LibcMalloc] =
HistoricMemoryCategoryInfo(MemoryCategory::LibcMalloc, Color::green, "libc
malloc");
> +    categories[MemoryCategory::bmalloc] =
HistoricMemoryCategoryInfo(MemoryCategory::bmalloc, SRGBA<uint8_t> { 255, 96,
96 }, "bmalloc");
> +    categories[MemoryCategory::IsoHeap] =
HistoricMemoryCategoryInfo(MemoryCategory::IsoHeap, SRGBA<uint8_t> { 128, 159,
64 }, "IsoHeap");
> +    categories[MemoryCategory::Other] =
HistoricMemoryCategoryInfo(MemoryCategory::Other, SRGBA<uint8_t> { 192, 255, 0
}, "Other");

In cases like this I'm not sure it's better to use named colors in the middle
of a bunch of hex values.