[webkit-reviews] review denied: [Bug 199444] [GTK] fast/events/context-activated-by-key-event.html is crashing : [Attachment 404505] Patch with platform guard
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 17 07:30:55 PDT 2020
Michael Catanzaro <mcatanzaro at gnome.org> has denied Lauro Moura
<lmoura at igalia.com>'s request for review:
Bug 199444: [GTK] fast/events/context-activated-by-key-event.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=199444
Attachment 404505: Patch with platform guard
https://bugs.webkit.org/attachment.cgi?id=404505&action=review
--- Comment #6 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 404505
--> https://bugs.webkit.org/attachment.cgi?id=404505
Patch with platform guard
I think you can simply remove the assert and avoid the need for ifdefs here. It
doesn't seem to be accomplishing anything: the following code doesn't look like
it's going to do the wrong thing if we are not processing mouse events.
More information about the webkit-reviews
mailing list