[webkit-reviews] review denied: [Bug 213364] [GStreamer] gst_buffer_unmap: assertion 'GST_IS_BUFFER (buffer)' failed : [Attachment 404443] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 17 03:27:39 PDT 2020


Philippe Normand <pnormand at igalia.com> has denied Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 213364: [GStreamer] gst_buffer_unmap: assertion 'GST_IS_BUFFER (buffer)'
failed
https://bugs.webkit.org/show_bug.cgi?id=213364

Attachment 404443: Patch

https://bugs.webkit.org/attachment.cgi?id=404443&action=review




--- Comment #2 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 404443
  --> https://bugs.webkit.org/attachment.cgi?id=404443
Patch

This looks like a workaround for a bug in the InitData class. As the init data
is quite small (IIRC), doesn't it pay off to have mapped buffer there? Can't we
just copy it? Also I see the append() method assuming the m_payload is mutable,
while the createSharedBuffer() has a comment mentioning it should be considered
immutable.


More information about the webkit-reviews mailing list