[webkit-reviews] review requested: [Bug 214441] Fix -Wformat= warnings when passing enum to integer specifiers : [Attachment 404535] Patch using uint8_t as underlying type

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 16 21:31:39 PDT 2020


Lauro Moura <lmoura at igalia.com> has asked  for review:
Bug 214441: Fix -Wformat= warnings when passing enum to integer specifiers
https://bugs.webkit.org/show_bug.cgi?id=214441

Attachment 404535: Patch using uint8_t as underlying type

https://bugs.webkit.org/attachment.cgi?id=404535&action=review




--- Comment #3 from Lauro Moura <lmoura at igalia.com> ---
Created attachment 404535

  --> https://bugs.webkit.org/attachment.cgi?id=404535&action=review

Patch using uint8_t as underlying type

The fast/mediastream tests worked as expected here with both enums
(WebCore::MediaConstraintType and WebCore::MediaConstraint::DataType) using
uint8_t as underlying type, but I'm not sure if there is any uncovered case
where it could be an issue.


More information about the webkit-reviews mailing list