[webkit-reviews] review granted: [Bug 214433] [iOS 14] Some PassKit SPI is now API : [Attachment 404495] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 16 16:47:05 PDT 2020


Darin Adler <darin at apple.com> has granted Jonathan Bedard <jbedard at apple.com>'s
request for review:
Bug 214433: [iOS 14] Some PassKit SPI is now API
https://bugs.webkit.org/show_bug.cgi?id=214433

Attachment 404495: Patch

https://bugs.webkit.org/attachment.cgi?id=404495&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 404495
  --> https://bugs.webkit.org/attachment.cgi?id=404495
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404495&action=review

> Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:330
> +#ifndef __PKPAYMENTMERCHANTSESSION_H__

This is not the ideal way to resolve this. Long term we would want to remove
this block entirely. Doing it this way means we could end up keeping this
forever.


More information about the webkit-reviews mailing list