[webkit-reviews] review granted: [Bug 214424] iPad cursor is sometimes slow to change to I-beam (e.g. on reddit.com) : [Attachment 404482] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 214424: iPad cursor is sometimes slow to change to I-beam (e.g. on
reddit.com)
https://bugs.webkit.org/show_bug.cgi?id=214424

Attachment 404482: Patch

https://bugs.webkit.org/attachment.cgi?id=404482&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 404482
  --> https://bugs.webkit.org/attachment.cgi?id=404482
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404482&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8675
> +	       auto deferredRequest =
WTFMove(_deferredCursorInteractionRequest);

Nit - I _think_ we prefer std::exchange for cases like this, where the
intention is to reset the thing being moved.

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2950
> +	   info.nodeAtPositionHasDoubleClickHandler =
m_page->mainFrame().nodeRespondingToDoubleClickEvent(request.point,
adjustedPoint);

I wonder if `nodeAtPositionHasDoubleClickHandler` should be an Optional<bool>
(or maybe a Yes/No/����‍♂️ enum class).