[webkit-reviews] review granted: [Bug 214326] Selection is not always clearing when tapping. : [Attachment 404476] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 214326: Selection is not always clearing when tapping.
https://bugs.webkit.org/show_bug.cgi?id=214326

Attachment 404476: Patch

https://bugs.webkit.org/attachment.cgi?id=404476&action=review




--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 404476
  --> https://bugs.webkit.org/attachment.cgi?id=404476
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404476&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2574
>		   if (!_page->editorState().selectionIsRange)
>		       return NO;
> -		   return [self _pointIsInsideSelectionRect:point
outBoundingRect:nil];
> +		   return YES;

Nit - this might be cleaner as just `return
_page->editorState().selectionIsRange;`

>
LayoutTests/editing/selection/ios/hide-selection-after-tap-on-prevent-default-e
lement.html:53
> +    //await UIHelper.delayFor(1000);

Nit - stray commented out code.