[webkit-reviews] review granted: [Bug 214380] [WebAuthn] Add a console message: "User gesture is required to use the platform authenticator." : [Attachment 404470] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 214380: [WebAuthn] Add a console message: "User gesture is required to use
the platform authenticator."
https://bugs.webkit.org/show_bug.cgi?id=214380

Attachment 404470: Patch

https://bugs.webkit.org/attachment.cgi?id=404470&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 404470
  --> https://bugs.webkit.org/attachment.cgi?id=404470
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404470&action=review

r=me

> Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:57
> +	   m_webPage.addConsoleMessage(webFrame->frameID(),
MessageSource::Other, MessageLevel::Warning, "User gesture is required to use
the platform authenticator."_s);

Is there any way we can make this message more descriptive?  There's barely
anything actionable here for a developer to use.  The fact that every log is
the exact same in the LayoutTests is indicative of the problem :(

Also, can you add `#include <JavaScriptCore/ConsoleTypes.h>`?