[webkit-reviews] review canceled: [Bug 214400] Double tapping to zoom out a fullscreen video will zoom in slightly before zooming out : [Attachment 404426] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 16 10:04:19 PDT 2020


Peng Liu <peng.liu6 at apple.com> has canceled Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 214400: Double tapping to zoom out a fullscreen video will zoom in slightly
before zooming out
https://bugs.webkit.org/show_bug.cgi?id=214400

Attachment 404426: Patch

https://bugs.webkit.org/attachment.cgi?id=404426&action=review




--- Comment #3 from Peng Liu <peng.liu6 at apple.com> ---
Comment on attachment 404426
  --> https://bugs.webkit.org/attachment.cgi?id=404426
Patch

This patch handles two video gravity changes differently:
1) AVLayerVideoGravityResizeAspect -> AVLayerVideoGravityResizeAspectFill,
2) AVLayerVideoGravityResizeAspectFill -> AVLayerVideoGravityResizeAspect).

The animation happens on the UI process for 1), and the animation happens on
the web process for 2). We had better let the animations happen on the UI
process for both cases.


More information about the webkit-reviews mailing list