[webkit-reviews] review granted: [Bug 214390] MiniBrowser toolbar is ugly with default macOS Big Sur style : [Attachment 404409] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 214390: MiniBrowser toolbar is ugly with default macOS Big Sur style
https://bugs.webkit.org/show_bug.cgi?id=214390

Attachment 404409: Patch

https://bugs.webkit.org/attachment.cgi?id=404409&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 404409
  --> https://bugs.webkit.org/attachment.cgi?id=404409
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404409&action=review

> Tools/MiniBrowser/mac/BrowserWindowController.m:46
> +#if TARGET_OS_OSX && __MAC_OS_X_VERSION_MIN_REQUIRED >= 110000

Why the TARGET_ check?

> Tools/MiniBrowser/mac/BrowserWindowController.m:51
> +    reloadButton.image = [NSImage
imageWithSystemSymbolName:@"arrow.clockwise"
accessibilityDescription:@"Reload"];

I believe it is possible to specify symbols in IB? But I could be wrong.