[webkit-reviews] review granted: [Bug 214315] [css-grid] CSSOM gridTemplateColumns/Rows reports wrong line names when leading implicit tracks are present : [Attachment 404335] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Oriol Brufau
<obrufau at igalia.com>'s request for review:
Bug 214315: [css-grid] CSSOM gridTemplateColumns/Rows reports wrong line names
when leading implicit tracks are present
https://bugs.webkit.org/show_bug.cgi?id=214315

Attachment 404335: Patch

https://bugs.webkit.org/attachment.cgi?id=404335&action=review




--- Comment #5 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 404335
  --> https://bugs.webkit.org/attachment.cgi?id=404335
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404335&action=review

Thanks for the fix.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:875
> +    ASSERT((unsigned)end <= tracks.size());

Do we need this cast?

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:920
> +	   // Named grid line indices are relative to the explicit grid, but we
are
> +	   // including all tracks. So we need to subtract the number of
leading
> +	   // implicit tracks in order to get the proper line index.

Nit: Comments lines can be longer in WebKit, no need to wrap to 80-chars.