[webkit-reviews] review denied: [Bug 214371] Remove a few more uses of the terms black/white list : [Attachment 404375] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied  review:
Bug 214371: Remove a few more uses of the terms black/white list
https://bugs.webkit.org/show_bug.cgi?id=214371

Attachment 404375: Patch

https://bugs.webkit.org/attachment.cgi?id=404375&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 404375
  --> https://bugs.webkit.org/attachment.cgi?id=404375
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404375&action=review

Looks good except the part that adds another file read.

> Source/WTF/wtf/URLHelpers.cpp:61
> +// Cocoa has an implementation that read this from a file in /Library or
~/Library.

reads

> Source/WTF/wtf/cocoa/NSURLExtras.mm:85
> +	       // FIXME: Remove this at some point after checking that no one
is depending on it.

I've tried to remove this in the past and was informed that it exists only for
third parties and we have no way of checking if they still use it.  There's
also an optimization for it in Foundation, which we should rename at the same
time.  I think we should do that instead of checking both filenames, which will
significantly adversely affect startup time of many things.