[webkit-reviews] review denied: [Bug 214338] Add some missing boilerplate to help fix build on macOS Big Sur : [Attachment 404372] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Saagar Jha
<saagar at saagarjha.com>'s request for review:
Bug 214338: Add some missing boilerplate to help fix build on macOS Big Sur
https://bugs.webkit.org/show_bug.cgi?id=214338

Attachment 404372: Patch

https://bugs.webkit.org/attachment.cgi?id=404372&action=review




--- Comment #14 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 404372
  --> https://bugs.webkit.org/attachment.cgi?id=404372
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404372&action=review

> Source/WebCore/PAL/pal/spi/mac/NSAppearanceSPI.h:36
>  - (void)_drawInRect:(NSRect)rect context:(CGContextRef)context
options:(NSDictionary *)options;

This will break our internal build.  This needs to be here for
APPLE_INTERNAL_SDK and not.  _usesMetricsAppearance only needs to be there for
not APPLE_INTERNAL_SDK.