[webkit-reviews] review denied: [Bug 214338] Add some missing boilerplate to help fix build on macOS Big Sur : [Attachment 404363] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 15 12:05:22 PDT 2020
Alex Christensen <achristensen at apple.com> has denied Saagar Jha
<saagar at saagarjha.com>'s request for review:
Bug 214338: Add some missing boilerplate to help fix build on macOS Big Sur
https://bugs.webkit.org/show_bug.cgi?id=214338
Attachment 404363: Patch
https://bugs.webkit.org/attachment.cgi?id=404363&action=review
--- Comment #12 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 404363
--> https://bugs.webkit.org/attachment.cgi?id=404363
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=404363&action=review
> Source/WebCore/PAL/pal/spi/mac/NSImageSPI.h:38
> ++ (nullable NSImage *)_imageWithSystemSymbolName:(NSString *)name;
It looks like you need to remove nullable here. Adding a nullability specifier
to an ObjC header makes it require nullability specifiers for all of them.
More information about the webkit-reviews
mailing list