[webkit-reviews] review granted: [Bug 214362] itsnicethat.com page is sometimes non-scrollable : [Attachment 404359] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 15 11:11:42 PDT 2020
Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 214362: itsnicethat.com page is sometimes non-scrollable
https://bugs.webkit.org/show_bug.cgi?id=214362
Attachment 404359: Patch
https://bugs.webkit.org/attachment.cgi?id=404359&action=review
--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 404359
--> https://bugs.webkit.org/attachment.cgi?id=404359
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=404359&action=review
> Source/WebCore/platform/graphics/cocoa/WebCoreCALayerExtras.mm:113
> + if ([self.mask isKindOfClass:[CAShapeLayer class]]) {
> + CAShapeLayer *shapeMask = static_cast<CAShapeLayer *>(self.mask);
I think you can merge these two lines with a dynamic_objc_cast (same above)
More information about the webkit-reviews
mailing list