[webkit-reviews] review denied: [Bug 214338] Add some missing boilerplate to help fix build on macOS Big Sur : [Attachment 404356] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Saagar Jha
<saagar at saagarjha.com>'s request for review:
Bug 214338: Add some missing boilerplate to help fix build on macOS Big Sur
https://bugs.webkit.org/show_bug.cgi?id=214338

Attachment 404356: Patch

https://bugs.webkit.org/attachment.cgi?id=404356&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 404356
  --> https://bugs.webkit.org/attachment.cgi?id=404356
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404356&action=review

Needs a tweak, but otherwise looks good.

> Source/WebCore/PAL/pal/spi/mac/NSAppearanceSPI.h:37
> +- (BOOL)_usesMetricsAppearance;

This should only be declared in #if !USE(APPLE_INTERNAL_SDK), otherwise it will
probably break an internal build because it's already declared.