[webkit-reviews] review granted: [Bug 213553] [ iOS macOS ] http/tests/resourceLoadStatistics/grandfathering-database.html is a rare flaky timeout : [Attachment 404294] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted katherine_cheney at apple.com's request
for review:
Bug 213553: [ iOS macOS ]
http/tests/resourceLoadStatistics/grandfathering-database.html is a rare flaky
timeout
https://bugs.webkit.org/show_bug.cgi?id=213553

Attachment 404294: Patch

https://bugs.webkit.org/attachment.cgi?id=404294&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 404294
  --> https://bugs.webkit.org/attachment.cgi?id=404294
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404294&action=review

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:2088
> +    bool notifyPagesWhenDataRecordsWereModified = !!callback;
> +    // Setting a callback implies we expect to receive callbacks. So
register for them.
> +   
setStatisticsNotifyPagesWhenDataRecordsWereScanned(notifyPagesWhenDataRecordsWe
reModified);

I understand turning this on if we were passed a callback.

I don’t fully understand turning it off if we were passed null. Are we the one
and only client? Does this need to be reset between tests?